Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to ember-copy #77

Merged
merged 1 commit into from
Jun 16, 2018
Merged

Switch to ember-copy #77

merged 1 commit into from
Jun 16, 2018

Conversation

wagenet
Copy link
Contributor

@wagenet wagenet commented Jun 15, 2018

@voltidev
Copy link
Collaborator

Thanks

@voltidev voltidev merged commit f4201bc into evoactivity:master Jun 16, 2018
@bgentry
Copy link

bgentry commented Jul 18, 2018

Thanks for fixing this @wagenet! Please publish a new release when you have the time @ivanvotti ✌️

@voltidev
Copy link
Collaborator

Done

buschtoens added a commit to buschtoens/ember-svg-jar that referenced this pull request Aug 4, 2018
AFAICT `asset.attrs` is a shallow object and does not implement the [`Copyable` interface][1]
or the `copy` method. Calling the `copy` function from ember-copy on it therefore only
creates a shallow copy.

This is exactly what [`assign`][2] does, when you assign into an empty object.

Referencing evoactivity#77.

[1]: https://www.emberjs.com/api/ember/release/classes/Ember.Copyable
[2]: https://emberjs.com/api/api/ember/release/functions/@ember%2Fpolyfills/assign
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants